[PATCH] optimize aio rw path
abartlet at samba.org
Wed Mar 26 16:15:42 MDT 2014
On Wed, 2014-03-26 at 13:39 +0100, Volker Lendecke wrote:
> Attached find a few patches that optimize our async I/O
> path. It might be a bit controversial, because it uses C99
> variable arrays. Here in this situation I think it really
> reduces code complexity and is important for performance.
> Review would be appreciated!
On the C99 issue. I fully support the use of variable arrays. I think
it is entirely reasonable to use this language feature. We actually
shipped a Samba 3.x release with this (hidden in the RPC GSSAPI
handler), but removed it later when we found a better way to handle it.
I think anything that makes it easier and more correct to code Samba
should be encouraged, and variable length arrays seem to fit the bill
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical