[PATCH] optimize aio rw path

Jeremy Allison jra at samba.org
Wed Mar 26 22:32:37 MDT 2014

On Wed, Mar 26, 2014 at 01:39:53PM +0100, Volker Lendecke wrote:
> Hi!
> Attached find a few patches that optimize our async I/O
> path. It might be a bit controversial, because it uses C99
> variable arrays. Here in this situation I think it really
> reduces code complexity and is important for performance.
> Review would be appreciated!

LGTM, pushed to autobuild. The only
thing that made me think a bit is
when you create the initial jobs
array you zero it via calloc, but
after you expand it via realloc/memcpy
the expanded area isn't zeroed.

Then I remembered the reason for
this patch is it's performance
critical code, and that if that
memory ever got read before
being written it's a horrible
logic bug anyway :-).



More information about the samba-technical mailing list