[PATCH] more FSRVP & additionally HRESULT error

Noel Power noel.power at suse.com
Fri Mar 21 11:16:57 MDT 2014

Hi Metz,
On 18/03/14 07:04, Stefan (metze) Metzmacher wrote:
> Hi Noel,
>> ok added full descriptions for existing const defines that had only the
>> short ( e.g. name of the const ) definition but were missing the full
>> description and also added both short and full descriptions for the
>> remaining, see top commit of
>> http://cgit.freedesktop.org/~noelp/noelp-samba/log/?h=heave_in_ntstatus
> Great thanks!
> Can you also publish the script you used?
> Similar to
> https://git.samba.org/?p=samba.git;a=blob;f=source4/scripting/bin/w32err_code.py;h=4ca6413e942
interesting didn't know the above existed, but.. sure I can publish mine 
( although it is pretty ropey and takes input from tables cut and pasted 
from the web page etc. I never intended it to be re-used )
> The same applies to the HRESULT generation.
> It would be also good if you could split
> http://cgit.freedesktop.org/~noelp/noelp-samba/commit/?h=heave_in_hresult-v2&id=be6cc634b31777044e4c7d5c93d0124bc41ad1b7
> to that the libcli/util/ changes are in there own commit.
> The rest should be combined with
> http://cgit.freedesktop.org/~noelp/noelp-samba/commit/?h=heave_in_hresult-v2&id=d0e9479324893f35b52012d7bddb5f244471a94a
sure I can do that, please be a little patient though, currently I am 
vacation and I don't have access to the script
> Thanks!
> metze

More information about the samba-technical mailing list