[PATCH] more FSRVP & additionally HRESULT error

Noel Power nopower at suse.com
Wed Mar 12 06:01:58 MDT 2014


Hi,

In addition to a recent patch see
https://lists.samba.org/archive/samba-technical/2014-March/098317.html (
and thanks for the review/push ) I realised that I missed some error
constants that were additionally defined in the fsvrp.idl file. These
errors are E_ACCESSDENIED, E_INVALIDARG & E_OUTOFMEMORY. In MS-FSRVP
these errors are mentioned as amongst the most common errors that can be
received from the combined group of FSRVP specific and general HRESULT
values. I notice we don't seem have definitions for the HRESULT errors
so I created a new file to contain those ( and additionally some fsrvp
specific changes to pick up any errors from there )
Now, it has to be said there are probably alot of errors that samba
might never see, it may be beneficial to strip some classes of errors
out (e.g. FACILITY_MEDIASERVER comes to mind) That said who knows, maybe
one of these errors could infact bubble up through various subsystems
indicating some freaky system library misconfiguration or whatnot so
maybe it does no harm...

The patch probably is too large to mail so please see (top 2 commits) on
branch
http://cgit.freedesktop.org/~noelp/noelp-samba/log/?h=heave_in_hresult

Anyway appreciate review/comments etc.

thanks,

Noel


More information about the samba-technical mailing list