[PATCH] more FSRVP & additionally HRESULT error

Stefan (metze) Metzmacher metze at samba.org
Wed Mar 12 06:24:31 MDT 2014

Hi Noel,

> In addition to a recent patch see
> https://lists.samba.org/archive/samba-technical/2014-March/098317.html (
> and thanks for the review/push ) I realised that I missed some error
> constants that were additionally defined in the fsvrp.idl file. These
> these errors are mentioned as amongst the most common errors that can be
> received from the combined group of FSRVP specific and general HRESULT
> values. I notice we don't seem have definitions for the HRESULT errors
> so I created a new file to contain those ( and additionally some fsrvp
> specific changes to pick up any errors from there )
> Now, it has to be said there are probably alot of errors that samba
> might never see, it may be beneficial to strip some classes of errors
> out (e.g. FACILITY_MEDIASERVER comes to mind) That said who knows, maybe
> one of these errors could infact bubble up through various subsystems
> indicating some freaky system library misconfiguration or whatnot so
> maybe it does no harm...
> The patch probably is too large to mail so please see (top 2 commits) on
> branch
> http://cgit.freedesktop.org/~noelp/noelp-samba/log/?h=heave_in_hresult

Looks very interesting!

Can you add a HRESULT structure similar to NTSTATUS and WERROR,
so that this is not mixed with uint32 values?

It would also be good to add some prefix to the constants, maybe
HRES_, similar to WERR_?

While your're doing script magic would it be possible that you
autogenerate the
ntstatus values, we've already done this for WERROR, but we're still
missing some


More information about the samba-technical mailing list