[PATCH] Support 52 byte DsBindInfo (Win2k12)

Bob Ziuchkovski bob.ziuchkovski at gmail.com
Wed Mar 5 20:30:16 MST 2014

On Wed, 2014-03-05 at 08:46 +0100, Stefan (metze) Metzmacher wrote:
> Hi Bob,
> > No problem.  Attached is the patch with my signed-off tag.
> > 
> > I have only tested joining against a 2012 R2 DC running in 2008 R2
> > functional level.  I didn't try joining against 2012 or 2012 R2
> > functional level.
> This patch is imcomplete, it just fixes the python exception
> and hides the bug.
> ndr_{push,pull,print}_drsuapi_DsBindInfo() is hand written in
> librpc/ndr/ndr_drsuapi.c and also needs to be updated.

Thanks for the review and feedback.  I took a stab at updating
ndr_drsuapi.c as requested, though I have to admit I don't entirely
understand that file.

Attached is the updated patch.  I verified that the build succeeds and I
can still join against my 2012R2 DC in 2008R2 functional level.  Other
than that I'm not entirely sure what else to test.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-librpc-Support-52-byte-DsBindInfo-Win2k12.patch
Type: text/x-patch
Size: 3834 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140305/83acfa6d/attachment.bin>

More information about the samba-technical mailing list