CTDB waf build

Martin Schwenke martin at meltin.net
Wed Jun 18 23:59:25 MDT 2014


On Wed, 18 Jun 2014 11:12:43 -0700, Amitay Isaacs <amitay at gmail.com>
wrote:

> Here's the first draft of the migration from autoconf to waf build for CTDB.
> 
> Currently, CTDB is configured and built separately from Samba (top-level
> build).  The integration of build requires some more work on lib/util, so
> it can be used in CTDB without bringing in too many samba dependencies.
> 
> Since these changes drop duplicate libraries (talloc/tevent/tdb/replace), I
> am not posting the patches on the mailing list.  The patches are available
> in ctdb-build branch of my samba tree.
> 
> 
> http://git.samba.org/?p=amitay/samba.git;a=shortlog;h=refs/heads/ctdb-build

Looks good to me.  The only nit is that:

    ctdb-mkversion: Support external VERSION specification

should go before:

    ctdb-build: Add waf build for CTDB

Reviewed-by: Martin Schwenke <martin at meltin.net>

However, I'm guessing that someone who knows waf should probably review
too...  ;-)

peace & happiness,
martin


More information about the samba-technical mailing list