YouCompleteMe

[Michael Adam]

Ok, I reviewed that patch and let Andreas push it
without going to the list, because I thought it
would not disturb anybody.

But I see that David's general concerns are justyfied to
some extent, especially the bloating when many more files
for various build environments would be added.

Sorry to have created disturbance.

I think samba has a history of adding small developer
convenience thingies to the tree from time to time,
e.g. "make ctags".

What do others think: Should we allow this kind of
convenience in the repo? Only in a special subdirectory?
Or not at all? I don't know.

Michael

On 2014-06-05 at 15:01 +0200, David Disseldorp wrote:
> On Thu, 05 Jun 2014 14:37:18 +0200, Andreas Schneider wrote:
> 
> > On Thursday 05 June 2014 13:58:16 David Disseldorp wrote:
> > > Hi Andreas,
> > > 
> > > On Thu,  5 Jun 2014 13:19:04 +0200 (CEST), Andreas Schneider wrote:
> > > > Author: Andreas Schneider <asn at samba.org>
> > > > Date:   Wed Apr 2 09:01:41 2014 +0200
> > > > 
> > > >     Add YouCompleteMe config.
> > > 
> > > Would have been good to see this go by the list beforehand...
> > > 
> > > I'm not a fan of seeing developer environment tools, editor modelines,
> > > add-ons and other accessories go into the source repo.
> > 
> > Why not? If you don't use it the file will not be loaded at all.
> 
> It's added bloat that is not in any way needed to develop, build,
> deploy, document, maintain, run or manage the Samba
> file/print/authentication servers and clients.
> 
> Once it's in the tree it's subject to the same code-review, maintenance
> and auditing work-flow that is applied to the rest of the code-base,
> inadvertently wasting other people's time.
> 
> Finally, it opens the flood gates for all other developer environment
> tools and add-ons. Any takers for a cscope database? ;)
> 
> > > IMO this kind of
> > > cruft should remain on the developers' system - people have differing
> > > setups.
> > 
> > This file is for telling the compiler where to find the header files. I don't 
> > think that you have different include directories inside the samba source 
> > directory than I have.
> 
> We already have a build system to perform this. Surely you can still use
> this tool if this file lives outside the Samba code-base.
> 
> Cheers, David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140605/8c862fde/attachment.pgp>