Removal of zlib, take 2.
jelmer at samba.org
Tue Jul 15 14:07:24 MDT 2014
On Tue, Jul 15, 2014 at 03:56:25PM -0400, Ira Cooper wrote:
> On Tue, Jul 15, 2014 at 12:07 PM, Jelmer Vernooij <jelmer at samba.org> wrote:
> > On Tue, Jul 15, 2014 at 11:58:03AM -0400, Ira Cooper wrote:
> > > Code for review is at:
> > > http://git.samba.org/?p=ira/wip.git;a=shortlog;h=refs/heads/zlib_removal
> > >
> > > This is the "remove zlib, and break all systems without zlib" version.
> I refreshed the branch, check the new check.
The checks in the current branch look reasonable to me.
> > > I copied the configure check used previously, so it should detect
> > libraries
> > > the exact same way we do today, just to avoid any issues with botching
> > the
> > > check.
> > >
> > > Regarding making zlib truly optional: I've made good progress on this
> > > front, but the patch is substantially more complex, because I didn't
> > fully
> > > listen to Volker ;). I also conditionalized zlib in the AD DC. It looks
> > > "plausible" that it should work, but I don't know the right tests to run,
> > > nor have a test environment of that type setup. So I'd like some
> > > assistance in getting those patches properly tested.
> > Does "make test" still pass without zlib installed on the system.
> I haven't gotten that far, I've been testing on a machine WITH zlib without
> linking against it.
> Which is why I suspect there's more I need to do. I need to setup a
> container to mess up and do the builds etc.
That's probably the only sensible way of getting a system without zlib
installed on it. On my system, pretty much everything depends on zlib,
directly or otherwise.
I still think removing the bundled zlib but at the same time making
zlib optional doesn't gain us anything useful, and comes with a cost.
Jelmer Vernooij <jelmer at samba.org> - https://jelmer.co.uk/
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 819 bytes
Desc: Digital signature
More information about the samba-technical