Arggghhh. Missing 'Signed-off-by:' and 'Reviewed-by:' in revert I pushed...

Kai Blin kai at
Tue Jul 15 02:01:50 MDT 2014

On 2014-07-15 09:54, Michael Adam wrote:
> Hmm,  I recall this from some past year's team meeting,
> not this one. Ah, of course it can be that either my
> brain is dissolving, or it is due to the fact that
> the team meeting was started eralier than scheduled
> without notice that I missed something... (scnr) ;-)
> I was just expressing the feasibility and my unchanged
> opinion that I think this is a good thing.
> Apart from that, any decision can be revisited.

Ok, I might be mistaken, maybe it was an earlier year. In any case, I'd 
like to renew my opposition to adding checks like this to autobuild.

If Jeremy wants to avoid accidentally pushing code without a sign-off, I 
would suggest using a pre-push hook on his local repository.


Kai Blin
Worldforge developer
Wine developer
Samba team member

More information about the samba-technical mailing list