Arggghhh. Missing 'Signed-off-by:' and 'Reviewed-by:' in revert I pushed...

Michael Adam obnox at
Tue Jul 15 00:01:49 MDT 2014

On 2014-07-14 at 17:11 -0700, Jeremy Allison wrote:
> Sorry all. I just realized I missed the
> Signed-off-by:Jeremy Allison <jra at>
> Reviewed-by: Stefan Metzmacher <metze at>
> tags in the revert I just pushed for
> bug
> Both Metze and I agreed this was needed,
> and I just forgot to add the tags
> (just had a brain-fart :-().
> Is it possible to add an autobuild
> filter to reject commits without
> the needed tags, so I *can't* screw
> up the tags again ?

This is certainly technically possible,
and in general I think it is the right thing to do.
We need to carefully write and test a script to
do the checks.

Should we, while at it, also think about a
prevention of patches without our agreed
bugzilla reference ("BUG: https://b.s.o/...")
getting into the release branches?

Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <>

More information about the samba-technical mailing list