Arggghhh. Missing 'Signed-off-by:' and 'Reviewed-by:' in revert I pushed...

[Kai Blin]

On 15/07/14 08:01, Michael Adam wrote:
> On 2014-07-14 at 17:11 -0700, Jeremy Allison wrote:
>> Sorry all. I just realized I missed the
>>
>> Signed-off-by:Jeremy Allison <jra at samba.org>
>> Reviewed-by: Stefan Metzmacher <metze at samba.org>
>>
>> tags in the revert I just pushed for
>> bug https://bugzilla.samba.org/show_bug.cgi?id=10692.
>>
>> Both Metze and I agreed this was needed,
>> and I just forgot to add the tags
>> (just had a brain-fart :-().
>>
>> Is it possible to add an autobuild
>> filter to reject commits without
>> the needed tags, so I *can't* screw
>> up the tags again ?
>
> This is certainly technically possible,
> and in general I think it is the right thing to do.
> We need to carefully write and test a script to
> do the checks.

Didn't we agree on the SambaXP team meeting to _not_ enforce this via 
technical measures?

Cheers,
Kai

-- 
Kai Blin
Worldforge developer http://www.worldforge.org/
Wine developer http://wiki.winehq.org/KaiBlin
Samba team member http://www.samba.org/samba/team/