SMB3 Multi-Channel (Re: What I'm working on)
Volker.Lendecke at SerNet.DE
Mon Jul 7 03:32:45 MDT 2014
On Mon, Jul 07, 2014 at 11:26:12AM +0200, Stefan (metze) Metzmacher wrote:
> Thanks for the review!
> I'll fix the renames from 'conn' into 'xconn' in the next days.
> I'm not exactly sure what to do with the
> tsocket_address_string() NULL checks, this is only used for DEBUG()
> statements and they should handle NULL fine.
That's true. But the link to "this is only for DEBUG" is not
really obvious in the code. Someone might later use this for
something else. Maybe something similar to 7a3bda5 would be
possible here as well?
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical