SMB3 Multi-Channel (Re: What I'm working on)

Stefan (metze) Metzmacher metze at
Mon Jul 7 03:26:12 MDT 2014

Hi Volker,

>>> I've cleanup up the preparation patches (82) ready for review in my
>>> branch, also attached.
>> And the attachment...
> Attached find the same patches with most of them r-b me,
> very few nit-picks and questions.

Thanks for the review!
I'll fix the renames from 'conn' into 'xconn' in the next days.

I'm not exactly sure what to do with the
tsocket_address_string() NULL checks, this is only used for DEBUG()
statements and they should handle NULL fine.

Should I add something like this?

if (addr == NULL) {
    addr = "<no memory>";

I'd prefer to avoid this and just pass NULL to DEBUG() which will result
in something like:
"<null>" or "(null)".


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 246 bytes
Desc: OpenPGP digital signature
URL: <>

More information about the samba-technical mailing list