smbcacls support for automatic inheritance propagation

[David Disseldorp]

On Thu, 30 Jan 2014 16:25:40 +0000, Noel Power wrote:

> On 30/01/14 15:41, Noel Power wrote:
> > thanks (updated patches to follow) Noel 
> I failed miserably with git send-mail, no doubt I have now a couple of
> patches in the moderation queue, please see
> http://cgit.freedesktop.org/~noelp/noelp-samba/log/?h=smbcacls_review%232 for
> the patches instead

This round looks good, there are a few more things I ran into during
testing/review:

prepare_inheritance_propagation() validates the command line ACL after
connecting to the share. I'd prefer it if this was done beforehand.

cacl_set() should use the same code path as inheritance_cacl_set(),
as it's basically the same as doing a inheritance_cacl_set() with
acl_no_propagate.

There are still some mixed declarations and code (lines 1620 and 1683).

Cheers, David