How do do bulk reviews?

Andrew Bartlett abartlet at
Sat Jan 25 18:31:45 MST 2014

On Fri, 2014-01-24 at 16:49 -0800, Jeremy Allison wrote:

> Thanks - going through make test right now.
> Once it passes I'll push (probably Monday morning
> pacific time. sorry).

Great.  Once that's in I'll push the sets Alexander reviewed for me, or
you can find them in my param-reviewed branch. 

But one question I had:  How do folks do the marking of bulk reviews
like this?  For small series, I just git rebase -i, and then reword the
commit message manually (or copy/paste), or when I'm doing it for
others, I git rebase -i and REVIEW=1 git commit --amend && git rebase
--continue using obnox's scripts.

But for this many, what I did was:

--stdout origin/master..HEAD -s > param-reviewed.patch

And then a search/replace in emacs for Signed-off-by: REPLACE <ME> with
Reviewed-by: Alexander Bokovoy <ab at>, then git reset --hard
origin/master && git am param-reviewed.patch to put the patchset back
onto a clean branch. 

It's a hack, so I'm curious what others do.  (My preferred review
interface - gitk - sadly doesn't have a 'review' checkbox, or else I
would love to just tick that as I go along). 


Andrew Bartlett

Andrew Bartlett             
Authentication Developer, Samba Team
Samba Developer, Catalyst IT

More information about the samba-technical mailing list