[PATCH] Second chunk of parameter internal variable renames
Alexander Bokovoy
ab at samba.org
Sat Jan 25 07:19:47 MST 2014
On Fri, Jan 24, 2014 at 04:49:04PM -0800, Jeremy Allison wrote:
> > > > > FN_LOCAL_XXXX text doesn't match on the first
> > > > > change. The second and subsequent patchsets
> > > > > then have the same problem :-(.
> > > > >
> > > > > Can you split out all the changes to the
> > > > > CamelCase -> camel_case parameters into
> > > > > one (large) set of patches patchset and
> > > > > I'll review them all in one go. I think
> > > > > that's the easiest way to stop running
> > > > > into silly gotcha's like this and get
> > > > > the rename in.
> > > >
> > > > Certainly. You probably didn't get the one I send Nadya, and it all
> > > > fell down from there. See attached for the full patch.
> > >
> > > Thanks. This LGTM. Let me pass it through a make
> > > test then I'll push (might not be until Monday,
> > > sorry).
> >
> > Thanks. Attached is a corrected patch due to a compile failure. It
> > looks like the szPrinterName patch I included (which we did later than
> > the rest) depended on another patch elsewhere in the series. This
> > series excludes that patch, we can handle szPrinterName case later with
> > the actual semantic changes.
> >
> > Thank you for all your time and patience with this.
>
> Thanks - going through make test right now.
>
> Once it passes I'll push (probably Monday morning
> pacific time. sorry).
Jeremy, thanks for rolling the ball. I'm travelling and often offline
for next two weeks, participating in few events that make hard to
review (sleep deprivation and talks/meetings ;)
--
/ Alexander Bokovoy
More information about the samba-technical
mailing list