[REVIEW REQUEST] recvmsg in socket_wrapper
asn at samba.org
Mon Jan 20 12:52:29 MST 2014
On Monday 20 January 2014 20:46:21 you wrote:
> Hi Andreas,
> > I've implemented the last missing function in socket_wrapper, recvmsg().
> > I've based it on the code metze created some time ago. Jakub wrote a fd
> > passing test and I've written a client server test. Please review the
> > code you can find here:
> > http://git.cryptomilk.org/projects/socket_wrapper.git/log/?h=recvmsg
> Thanks! It's nice to see that my work is finally finished:-)
> However I don't see were you transfer the 'struct socket_info' transparently
> while doing fd-passing. Otherwise it's not possible to pass socket fds
> across to another process.
Well, the fd-passing is handled in the kernel. I can't fake the kernel
internals here :) That's why you can only pass fds on the local system over
> Otherwise I think it looks good, can you also backport this
> to the current samba socket_wrapper code, I'd like to have that
> also more or less complete before we remove/replace it with your
> new code.
I can take a look.
Andreas Schneider GPG-ID: CC014E3D
Samba Team asn at samba.org
More information about the samba-technical