[PATCH] some fixes for waf issues
jelmer at samba.org
Wed Jan 15 16:48:27 MST 2014
On Thu, Jan 16, 2014 at 12:37:13PM +1300, Andrew Bartlett wrote:
> On Wed, 2014-01-15 at 22:21 +0100, Christian Ambach wrote:
> > + if default_dos_charset is False or default_unix_charset is
> > False:
> > + # we found iconv, but it failed to convert anything (e.g. on
> > AIX)
> > + conf.undefine('HAVE_NATIVE_ICONV');
> > + default_dos_charset = "ASCII"
> > + default_unix_charset = "UTF8"
> > +
> Please be consistent and use UTF-8. (It seems silly, but we have
> pending some tests that compare the docs with our testparm-indicated
> Otherwise, these look OK. Just make sure we undo the build farm changes
> once this is pushed to autobuild.
> Any further thoughts from your side?
It's not particularly neat to unset defines that were set earlier
rather than not setting them in the first place. I don't think that
should be a blocker for getting these changes in though.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 819 bytes
Desc: Digital signature
More information about the samba-technical