[PATCH] some fixes for waf issues

Andrew Bartlett abartlet at samba.org
Wed Jan 15 16:37:13 MST 2014

On Wed, 2014-01-15 at 22:21 +0100, Christian Ambach wrote:
> +        if default_dos_charset is False or default_unix_charset is
> False:
> +        # we found iconv, but it failed to convert anything (e.g. on
> AIX)
> +            conf.undefine('HAVE_NATIVE_ICONV');
> +            default_dos_charset = "ASCII"
> +            default_unix_charset = "UTF8"
> +

Please be consistent and use UTF-8.  (It seems silly, but we have
pending some tests that compare the docs with our testparm-indicated

Otherwise, these look OK.  Just make sure we undo the build farm changes
once this is pushed to autobuild. 


Any further thoughts from your side?

Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list