[PATCH] Remove "read raw" and "write raw" (make inverted synonym for "async smb echo handler")

Andrew Bartlett abartlet at samba.org
Wed Jan 15 01:01:25 MST 2014

On Wed, 2014-01-15 at 08:02 +0100, Volker Lendecke wrote:
> On Wed, Jan 15, 2014 at 06:24:14PM +1300, Andrew Bartlett wrote:
> > On Wed, 2014-01-15 at 14:56 +1300, Andrew Bartlett wrote:
> > > Jeremy,
> > > 
> > > Per our chat this morning, this patch helps remove an annoying special
> > > case in our loadparm system.  You indicated that this was only really
> > > needed for broken Ethernet adaptors on Win95, so I think it's safe to
> > > have go away, but just in case, I've made it an inverted synonym of
> > > 'async smb echo handler' which is why it became a special case in the
> > > first place.  
> > > 
> > > Can you please comment or review?
> > 
> > Attached is a corrected patch.
> We have quite a few of these dependencies for aio, sendfile,
> write cache and possibly others. Making a smb feature depend
> on something completely different seems wrong to me. If you
> want this out of the loadparm layer, can't you add the
> async echo check to the place where lp_readwraw is used,
> just moving it out of loadparm.c and into negprot.c?

I'll do that.  I agree the deprecated inverted synonym was just a bit
'too cute'. 

We also need a good, clear pattern for how to express these dependencies
across the codebase, and in the SMB server in particular. 

For a future, distinct patch, aside from the interaction with the async
smb echo handler, do you think we still need read raw and write raw as
specific smb.conf options?  


Andrew Bartlett

Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list