[PATCH] Remove "read raw" and "write raw" (make inverted synonym for "async smb echo handler")

[Volker Lendecke]

On Wed, Jan 15, 2014 at 06:24:14PM +1300, Andrew Bartlett wrote:
> On Wed, 2014-01-15 at 14:56 +1300, Andrew Bartlett wrote:
> > Jeremy,
> > 
> > Per our chat this morning, this patch helps remove an annoying special
> > case in our loadparm system.  You indicated that this was only really
> > needed for broken Ethernet adaptors on Win95, so I think it's safe to
> > have go away, but just in case, I've made it an inverted synonym of
> > 'async smb echo handler' which is why it became a special case in the
> > first place.  
> > 
> > Can you please comment or review?
> 
> Attached is a corrected patch.

We have quite a few of these dependencies for aio, sendfile,
write cache and possibly others. Making a smb feature depend
on something completely different seems wrong to me. If you
want this out of the loadparm layer, can't you add the
async echo check to the place where lp_readwraw is used,
just moving it out of loadparm.c and into negprot.c?

Or alternatively, make the echo handler depend on read and
write raw being off?

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de