[PATCH] Fix bug #2662 - revamped directory handling code is not 64bit clean

David Disseldorp ddiss at suse.de
Tue Jan 14 12:34:58 MST 2014


On Mon, 13 Jan 2014 11:21:56 -0800
Jeremy Allison <jra at samba.org> wrote:

> I finally felt bad enough about the new
> directory code on 64-bit servers breaking
> old DOS clients that I coded up a fix
> for it over the weekend :-).
> 
> It adds a memcache map into the smbd
> internal directory struct - only initialized
> when old DOS-style search requests come in,
> so it should have zero effect on modern
> clients. It creates a map from 64-bit
> directory offset cookies and an incrementing
> counter for the directory, which is used
> as the 32-bit DOS cookie.
> 
> Andreas and David - I think Red Hat and
> SuSE customers have suffered most from
> this so I'm hoping you can review it
> for me (or Ira, if you have time.. :-).

The changes look okay to me too.
Reviewed-by: David Disseldorp <ddiss at samba.org>

Cheers, David


More information about the samba-technical mailing list