[PATCH] Fix bug #2662 - revamped directory handling code is not 64bit clean

Andreas Schneider asn at samba.org
Tue Jan 14 08:45:38 MST 2014

On Monday 13 January 2014 11:21:56 Jeremy Allison wrote:
> I finally felt bad enough about the new
> directory code on 64-bit servers breaking
> old DOS clients that I coded up a fix
> for it over the weekend :-).
> It adds a memcache map into the smbd
> internal directory struct - only initialized
> when old DOS-style search requests come in,
> so it should have zero effect on modern
> clients. It creates a map from 64-bit
> directory offset cookies and an incrementing
> counter for the directory, which is used
> as the 32-bit DOS cookie.
> Andreas and David - I think Red Hat and
> SuSE customers have suffered most from
> this so I'm hoping you can review it
> for me (or Ira, if you have time.. :-).
> Re-enables the base.dir2 and raw.search
> tests as we now pass them cleanly on
> 64-bit boxes.

Thanks Jeremy, the patchset looks fine for me. I will wait for others to 
complain till tomorrow then I will push it.

	-- andreas

Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org

More information about the samba-technical mailing list