[PATCH] Fix bug 9227, make our XML documentation consistent with our code and prove it stays that way
abartlet at samba.org
Mon Jan 13 20:31:41 MST 2014
The work on our docs and loadparm system continues. See
This set of patches:
- renames the loadparm internal variables to match the lp_functions and
so to conform more closely to our coding guidelines.
- sets default values in lib/param and source3/param where these were
not set (due to divergence in new parameters during the s3/s4 split)
- corrects our documentation to match the code, including the
currently-unused metadata describing the parameter type etc.
- generates correct default paths in 'man smb.conf' by using the
dynconfig output from configure.
- fixes samba-tool testparm to work more like testparm
- updates docs.py to parse the documentation as XML, and to check the
default value against testparm (both versions). It is this that found
so many of the errors, and it is this that makes so much of the rest of
these changes reasonable and safe.
Please review. There is a lot of work in here (>550 patches), but each
is a small, independent and on it's own reasonable part. We understand
the renames are controversial, and the generation of parts of this
system from the XML is not yet presented nor a fully accepted idea, but
there is much, much more in this patch series set than just those
The most important step for any future improvement in loadparm is to get
the current state internally consistent, and that is essentially all
these patches do.
Garming and I have looked over the whole series carefully, multiple
times, and are confident is is correct. The patches over which we have
any concern have also been posted separately, for specific attention.
Garming will present his code generator for param_functions.c in the
next day or so, followed by modes to generate the other dependent
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical