[PATCHES] More logging for dbwrap_ctdb

Christof Schmitt cs at samba.org
Mon Jan 13 16:36:20 MST 2014


On Mon, Jan 13, 2014 at 04:04:00PM -0700, Christof Schmitt wrote:
> On Mon, Jan 13, 2014 at 11:51:26PM +0100, Volker Lendecke wrote:
> > On Mon, Jan 13, 2014 at 01:41:22PM -0700, Christof Schmitt wrote:
> > > The attached patches add more logging to ctdb and tdb calls in
> > > dbwrap_ctdb. This allows detecting and debugging the fcntl lock
> > > scalability problems on tdb files.
> > 
> > NAK on those :-)
> > 
> > We need to do the parameters differently, doing
> > lp_parm_something in such a hot code path is way too
> > expensive.
> 
> We could lookup the parameters in db_open_ctdb and store the settings in
> db_ctdb_ctx. Would that be enough?

Or would introducing formal parameter like we already have with "ctdb
locktime warn threshold" be the better approach?

Christof


More information about the samba-technical mailing list