[PATCH] s3: set native os according to Windows and NBT_ANNOUNCE_VERSION defines

Andrew Bartlett abartlet at samba.org
Mon Jan 13 13:35:30 MST 2014

On Mon, 2014-01-13 at 10:43 +0100, Björn Jacke wrote:
> On 2014-01-08 at 07:37 +1300 Andrew Bartlett sent off:
> > On Tue, 2014-01-07 at 15:57 +0100, Björn Jacke wrote:
> > > When the native os in sessionsetup is "Unix" then broken Konica Minolta
> > > printers refuse to talk to those CIFS servers. Other CIFS servers also announce
> > > themselves with native os Windows. Let's do the same to improve
> > > interoperability with broken devices like those printers from Konica Minolta.
> > > Thanks to Daniel Hoffmann for finding and reporting this Konika printer
> > > brokenness.
> > > 
> > > This fixes Bug #10168.
> > 
> > I do worry what the engineer that deliberately added this insane check
> > will add next (such as checking the next string, which I would be much
> > more worried about changing, due to loss of debugging).  However, I'm
> > not objecting to the concept. 
> I don't see a loss of debugging here. I decided to fix it this way and not
> make it an option intentionally cause to have this an option doesn't buy us
> anything. We would just have another option which confuses people and which
> actually nobody hardly ever needs. In the session setup there are bits which
> reveal much more reliable what kind of server we are. Actually there is still
> the String Samba+Version number also here. Just "Unix" is replaced with
> "Windows SAMBA_MAJOR_NBT_ANNOUNCE_VERSION". The biggest competitor of us does
> also announces as "Windows xxx" as native OS.

As I said, I don't object to replacing "Unix".

Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140114/c5a7cd86/attachment.pgp>

More information about the samba-technical mailing list