[PATCH] Re: netlogon_creds_cli_validate() in master4-schannel

[Andrew Bartlett]

On Tue, 2014-01-07 at 09:54 +0100, Stefan (metze) Metzmacher wrote:
> Am 07.01.2014 09:18, schrieb Andrew Bartlett:
> > On Tue, 2014-01-07 at 08:51 +0100, Stefan (metze) Metzmacher wrote:
> >> Hi Andrew,
> >>
> >>>
> >>>> Windows 2008r2 and Windows 2012 also work just fine:
> >>>>
> >>>> https://www.samba.org/~metze/ads/caps/netlogon/v4-0-schannel/20140105/
> >>>>
> >>>> I'll test NT4.0 SP6a and more Samba versions tomorrow.
> >>
> >> Testing against Samba: 3.0, 3.2, 3.4, 3.5, 3.6
> >> and Windows: NT4.0SP6a, 2000, 2008R2, 2012
> >> are all successful.
> > 
> > Great!
> > 
> >> I'm now waiting for the 58 private autobuilds to finish...
> > 
> > Umm, why?
> > 
> > (I hope it wasn't in response to my suggestion around the make test and
> > docs.py, I follow the bisectable rule when obvious and
> > trivial/practical, but this seems extreme). 
> 
> So 'make test TESTS=doc' with every commit is what you want?

You can do that if you like, but you have already done all I ever
wanted.  

What I meant was:  When adding a parameter, add the doc xml file in the
same commit (ie, the squash you did).  That is all!

We have a test, which avoids us releasing with undocumented parameters
and documentation for removed parameters.  Adding the parameter and doc
in the same commit keeps this happy.  Garming is working to soon extend
this to confirm the defaults match, so in the future I would suggest you
set the default at the same time as well. 

If you like, perhaps put the energy you were going to put into that into
reviewing our rename-param branch. 

git://git.catalyst.net.nz/samba.git rename-param

http://git.catalyst.net.nz/gitweb?p=samba.git;a=shortlog;h=refs/heads/rename-param

Thanks!

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba