Coverity-Id: 1167990 (Re: [SCM] Samba Shared Repository - branch master updated)

[Stefan (metze) Metzmacher]

Hi Ira,

> diff --git a/libcli/auth/netlogon_creds_cli.c b/libcli/auth/netlogon_creds_cli.c
> index d73335d..7e88255 100644
> --- a/libcli/auth/netlogon_creds_cli.c
> +++ b/libcli/auth/netlogon_creds_cli.c
> @@ -1766,8 +1766,8 @@ struct tevent_req *netlogon_creds_cli_ServerPasswordSet_send(TALLOC_CTX *mem_ctx
>  
>  	if (new_version != NULL) {
>  		struct NL_PASSWORD_VERSION version;
> -		uint32_t len = IVAL(state->samr_crypt_password.data, 512);
> -		uint32_t ofs = 512 - len;
> +		int32_t len = IVAL(state->samr_crypt_password.data, 512);
> +		int32_t ofs = 512 - len;
>  		uint8_t *p;

This is not the change we agreed to! Please revert this and push the
patch I reviewed!

Thanks!
metze