Volker Lendecke Volker.Lendecke at SerNet.DE
Mon Feb 17 03:04:51 MST 2014

On Mon, Feb 17, 2014 at 01:58:19PM +1300, Andrew Bartlett wrote:
> I've reviewed all of these, and uploaded them with review tags to 
> +topic:garming/macro-return,n,z
> git:// macro-return
> Naturally, I don't propose to push them until Kamen's concerns over the
> coding style itself are addressed or withdrawn. 

One other thing: In the past we have always avoided sweeping
changes over the code for two reasons:

It clutters git blame and it makes backports harder than

I 100% agree we should try to follow what's in
README.Coding, and I also 100% agree that control-flow
changing macros are bad, but I value backport ease higher
than hygiene for existing code.

So -1 from my side for these sweeping changes, sorry for
that. This is just my opinion.

With best regards,

Volker Lendecke

SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen, mailto:kontakt at

More information about the samba-technical mailing list