Removing the NT_STATUS_HAVE_NO_MEMORY_AND_FREE macro

[Nadezhda Ivanova]

While I agree with Volker on the subject of sweeping changes, this
particular change does not seem all that sweeping to me, it affects less
than 10 files. I am also of the opinion that return in a macro is awful,
and would sacrifice code beauty for easy of debugging and safety of use any
day, sorry, Kamen, so on these grounds at least I think the patches are
OK...


On Mon, Feb 17, 2014 at 12:04 PM, Volker Lendecke <Volker.Lendecke at sernet.de
> wrote:

> On Mon, Feb 17, 2014 at 01:58:19PM +1300, Andrew Bartlett wrote:
> > I've reviewed all of these, and uploaded them with review tags to
> > https://gerrit.sernet.de/#/q/status:open+project:samba+branch:master
> > +topic:garming/macro-return,n,z
> >
> > git://git.samba.org/abartlet/samba.git macro-return
> >
> > Naturally, I don't propose to push them until Kamen's concerns over the
> > coding style itself are addressed or withdrawn.
>
> One other thing: In the past we have always avoided sweeping
> changes over the code for two reasons:
>
> It clutters git blame and it makes backports harder than
> necessary.
>
> I 100% agree we should try to follow what's in
> README.Coding, and I also 100% agree that control-flow
> changing macros are bad, but I value backport ease higher
> than hygiene for existing code.
>
> So -1 from my side for these sweeping changes, sorry for
> that. This is just my opinion.
>
> With best regards,
>
> Volker Lendecke
>
> --
> SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
> phone: +49-551-370000-0, fax: +49-551-370000-9
> AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
> http://www.sernet.de, mailto:kontakt at sernet.de
>