[PATCH 1/3] build: don't execute tests/summary.c
abartlet at samba.org
Tue Feb 11 11:13:10 MST 2014
On Sat, 2014-02-08 at 06:47 +1300, Andrew Bartlett wrote:
> On Sun, 2014-02-02 at 13:45 +1300, Andrew Bartlett wrote:
> > On Thu, 2014-01-30 at 17:59 -0300, Gustavo Zacarias wrote:
> > > tests/summary.c will never be able to be executed when cross compiling.
> > > Use #error and #warning directives to fail or warn accordingly when
> > > compiling it.
> > Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> > Can I get a second Team reviewer please?
> Can you give me the second team review on this?
Can you please review this for me? It is quite harmless - we forgot to
even try summary.c for ages in waf, moving to compile-time checks seems
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical