[PATCH 1/3] build: don't execute tests/summary.c
kamenim at samba.org
Tue Feb 11 11:19:00 MST 2014
Here it goes:
Reviewed-by: Kamen Mazdrashki <kamenim at samba.org>
On Tue, Feb 11, 2014 at 7:13 PM, Andrew Bartlett <abartlet at samba.org> wrote:
> On Sat, 2014-02-08 at 06:47 +1300, Andrew Bartlett wrote:
> > On Sun, 2014-02-02 at 13:45 +1300, Andrew Bartlett wrote:
> > > On Thu, 2014-01-30 at 17:59 -0300, Gustavo Zacarias wrote:
> > > > tests/summary.c will never be able to be executed when cross
> > > > Use #error and #warning directives to fail or warn accordingly when
> > > > compiling it.
> > >
> > > Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> > >
> > > Can I get a second Team reviewer please?
> > David,
> > Can you give me the second team review on this?
> > Thanks,
> Can you please review this for me? It is quite harmless - we forgot to
> even try summary.c for ages in waf, moving to compile-time checks seems
> quite reasonable.
> Andrew Bartlett
> Andrew Bartlett http://samba.org/~abartlet/
> Authentication Developer, Samba Team http://samba.org
> Samba Developer, Catalyst IT
More information about the samba-technical