[PATCH] Fix bug #10406 - vfs_dirsort can trample on its own private data.

Andrew Bartlett abartlet at samba.org
Tue Feb 11 03:14:58 MST 2014


On Mon, 2014-02-10 at 21:31 -0800, Jeremy Allison wrote:
> Now tested and confirmed good by the OEM who reported it,
> this patch fixes the problem that the current dirsort
> module only keeps one active private data pointer on
> the connection struct, so opening a second directory
> on the same connection will overwrite it.
> 
> Please review & push if happy !

Can you make sure that in 'make test' we now run raw.search and the os2
delete test against the tmpenc share (or perhaps better a new share for
this purpose) that uses dirsort?  It would be great to ensure this is
tested.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list