[PATCH] Fix bug #10406 - vfs_dirsort can trample on its own private data.

Jeremy Allison jra at samba.org
Tue Feb 11 10:05:08 MST 2014

On Tue, Feb 11, 2014 at 11:14:58PM +1300, Andrew Bartlett wrote:
> On Mon, 2014-02-10 at 21:31 -0800, Jeremy Allison wrote:
> > Now tested and confirmed good by the OEM who reported it,
> > this patch fixes the problem that the current dirsort
> > module only keeps one active private data pointer on
> > the connection struct, so opening a second directory
> > on the same connection will overwrite it.
> > 
> > Please review & push if happy !
> Can you make sure that in 'make test' we now run raw.search and the os2
> delete test against the tmpenc share (or perhaps better a new share for
> this purpose) that uses dirsort?  It would be great to ensure this is
> tested.

Bleegh. It's a fair cop :-). Now I have to figure out how
to run one specific test only against one specific share :-).


More information about the samba-technical mailing list