[PATCH] Fix the last of the defaults and include a test to check them

Andrew Bartlett abartlet at samba.org
Sat Feb 1 13:12:34 MST 2014

On Sat, 2014-02-01 at 13:39 +0100, Michael Adam wrote:
> On 2014-01-31 at 21:09 +0100, Michael Adam wrote:
> > On 2014-02-01 at 09:05 +1300, Andrew Bartlett wrote:
> > > 
> > > I've just re-pushed all the outstanding branches. 
> > 
> > Alright will try to look after that, hopefully over the week-end.
> I have looked over all the metadata patches.
> I have tagged most of them as reviewed-by-me.
> See my master-param branch:
> https://git.samba.org/?p=obnox/samba/samba-obnox.git;a=shortlog;h=master-param
> But there are some questions:
> (commits messages marked with "TODO(...) " and not flagged as
> reviewed yet.)
> For some of the parameters, when adding metadata, you don't add
> a function or generated_function field. Is that missing?
> Or what are the systematics here?

The idea is that, by default the generate-param.py script shouldn't need
this.  Ideally the function should be the name of the parameter, with
spaces becoming _.  Ideally the build system would always generate the
matching function.  Sadly we are very inconsistent in our names here,
and so much more metadata is required than I ever imagined, and what
existed was so often incorrect.  Thankfully Garming was able to script
the additions, but what looks like a special case was really meant to be
the default/normal case :-).

We also don't need it on synonyms (no function is generated in this

> One other thing is that you changed the mask/mode parameters
> to type integer. In the param-table, they are "octal", so I
> was wondering whether there is anything special needed here?

You are entirely correct, this should be a different type.  We get away
with it because for the things so far generated, they are 'just'

This and many other of the details encoded in the param_table.c (such as
the ordering, sections, flags, special handler and enumeration types),
will need to be added before we can generate that table. 

Garming, can you make sure we look into and fix this up before we finish
working on this?

Andrew Bartlett

Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list