[PATCH] Fix the last of the defaults and include a test to check them
obnox at samba.org
Sat Feb 1 05:39:14 MST 2014
On 2014-01-31 at 21:09 +0100, Michael Adam wrote:
> On 2014-02-01 at 09:05 +1300, Andrew Bartlett wrote:
> > I've just re-pushed all the outstanding branches.
> Alright will try to look after that, hopefully over the week-end.
I have looked over all the metadata patches.
I have tagged most of them as reviewed-by-me.
See my master-param branch:
But there are some questions:
(commits messages marked with "TODO(...) " and not flagged as
For some of the parameters, when adding metadata, you don't add
a function or generated_function field. Is that missing?
Or what are the systematics here?
One other thing is that you changed the mask/mode parameters
to type integer. In the param-table, they are "octal", so I
was wondering whether there is anything special needed here?
Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 215 bytes
Desc: Digital signature
More information about the samba-technical