Why our autobuilds fail (was: Re: Make sure --with-profiling-data keeps compiling)

[Volker Lendecke]

On Tue, Dec 16, 2014 at 05:29:05PM +1300, Andrew Bartlett wrote:
> On Mon, 2014-12-15 at 12:48 +0100, Michael Adam wrote:
> > Reviewed-by: /me
> > 
> > On 2014-12-15 at 10:40 +0100, Stefan (metze) Metzmacher wrote:
> > > Hi,
> > > 
> > > here's a patch that makes sure that --with-profiling-data keeps compiling.
> > > 
> > > metze
> > > 
> 
> Sadly, I think we need to revert this.
> 
> The issue is, as I read the code and the failed autobuilds, is that the
> first user (your good self) to run this on sn-devel created a shared
> memory segment with a fixed key.  See
> source3/profile/profile.c:profile_setup().
> 
> All other builds attempt to create the same shared memory segment, and
> refuse to, because they don't own it.  This then causes all autobuilds
> to fail. 
> 
> This isn't an issue in production, as it will always be root, but were a
> distribution to install Samba with this option enabled, it would prevent
> the non-root use of smbd (eg qemu) by multiple users, per reboot.
> 
> Can we store the profiling data in a tdb, or at least make the key
> random and put it in a tdb, and can we wipe shared memory segments at
> autobuild completion?

Metze, can we get
https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=25ee2483ce3d887d53f72086
on the car pool lane? :-)

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de