Why our autobuilds fail (was: Re: Make sure --with-profiling-data keeps compiling)

Andrew Bartlett abartlet at samba.org
Mon Dec 15 21:29:05 MST 2014


On Mon, 2014-12-15 at 12:48 +0100, Michael Adam wrote:
> Reviewed-by: /me
> 
> On 2014-12-15 at 10:40 +0100, Stefan (metze) Metzmacher wrote:
> > Hi,
> > 
> > here's a patch that makes sure that --with-profiling-data keeps compiling.
> > 
> > metze
> > 

Sadly, I think we need to revert this.

The issue is, as I read the code and the failed autobuilds, is that the
first user (your good self) to run this on sn-devel created a shared
memory segment with a fixed key.  See
source3/profile/profile.c:profile_setup().

All other builds attempt to create the same shared memory segment, and
refuse to, because they don't own it.  This then causes all autobuilds
to fail. 

This isn't an issue in production, as it will always be root, but were a
distribution to install Samba with this option enabled, it would prevent
the non-root use of smbd (eg qemu) by multiple users, per reboot.

Can we store the profiling data in a tdb, or at least make the key
random and put it in a tdb, and can we wipe shared memory segments at
autobuild completion?

Thanks,

Andrew Bartlett


-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba






More information about the samba-technical mailing list