[PATCH 00/31] Add complete DNS Faking using resolv_wrapper.

Andrew Bartlett abartlet at samba.org
Fri Dec 5 10:17:03 MST 2014

On Wed, 2014-12-03 at 15:44 +0100, Andreas Schneider wrote:
> Hello,
> the following patchset integrates resolv_wrapper 1.1.0 to Samba and uses
> it in DNS faking mode. Currently we have some bugs in our DNS server
> which don't allow to use it. Until this is fixed we will operate in DNS
> faking mode on all platforms. It will be easy to change this later.
> Implementing DNS faking this way allows 3rd party applications to also
> do DNS queries using libresolv. This allows us to correctly test the
> Samba DC with MIT Kerberos and also the Samba libraries which use DNS
> queries to find out the IP of the DC will always use the codepath they
> will use in a real evironment.
> Please review soon as we need this to finish our MIT Kerberos work!
> The patches are available in git too:
> https://git.samba.org/?p=asn/samba.git;a=shortlog;h=refs/heads/resolv_wrapper

Thanks!  These look good, I just have a few issues with the order, and
would like whatever is breaking nsupdate against our DC fixed before
this goes in.

In terms of ordering, I would like 

[PATCH 27/31] selftest: Always enable dns fakeing

to go away, and 
[PATCH 25/31] selftest: Add support for dns faking in Samba4 target

to go in before the hooks for dns_host_files go out.  That should keep
make test bisectable.  That is, please ensure a simple DNS-using test
keeping working on every commit, where practical. 

I'm really glad to see my dns_hosts_file hack go away, and this is
really impressive work.

Otherwise I'm happy, and I'll review/push the rwrap import now, and the
selftest changes after we go another round. 


Andrew Bartlett

Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list