[PATCH 00/31] Add complete DNS Faking using resolv_wrapper.

Andreas Schneider asn at samba.org
Mon Dec 8 05:38:58 MST 2014

On Saturday 06 December 2014 06:17:03 Andrew Bartlett wrote:
> > The patches are available in git too:
> > 
> > https://git.samba.org/?p=asn/samba.git;a=shortlog;h=refs/heads/resolv_wrap
> > per
> Thanks!  These look good, I just have a few issues with the order, and
> would like whatever is breaking nsupdate against our DC fixed before
> this goes in.

Thanks for pushing the first set of patches!

> In terms of ordering, I would like
> [PATCH 27/31] selftest: Always enable dns fakeing
> to go away,

The issue here is that Kai doesn't have much time to look into this and this 
is blocking Günther and me from finishing the MIT Kerberos branch.

I could start to look into DNS but this will take some time cause I need to 
read the RFC first and then write new tests so we have a base against Windows 
to start with.

As far as I understood there are several issues.

a) the DNS server is not async, which is needed to fix this.
b) Our signature checking doesn't work correctly so we handle packets which a 
wrong signature correctly.
c) More tests

> and
> [PATCH 25/31] selftest: Add support for dns faking in Samba4 target
> to go in before the hooks for dns_host_files go out.  That should keep
> make test bisectable.  That is, please ensure a simple DNS-using test
> keeping working on every commit, where practical.

I've reordered the patches and updated the git repository.

> I'm really glad to see my dns_hosts_file hack go away, and this is
> really impressive work.
> Otherwise I'm happy, and I'll review/push the rwrap import now, and the
> selftest changes after we go another round.

I could squash the patches so dns faking is the default from the beginning. We 
need it anyway on non-Linux platforms. Talking to the real DNS server only 
works on Linux cause we have a libresolv.so. Other systems implement it 
directly in libc or do not have thread-safe variants.

	-- andreas

Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org

More information about the samba-technical mailing list