[PATCH v2 1/3] generic/013: encapsulate remount during cleanup

Pavel Shilovsky piastryyy at gmail.com
Thu Aug 28 12:50:36 MDT 2014

>> 28 авг. 2014 г., в 21:08, Christoph Hellwig <hch at infradead.org> написал(а):
>> On Wed, Aug 27, 2014 at 12:28:36AM +0400, Pavel Shilovsky wrote:
>> The existing code calls remount for $TEST_DEV with constantly defined
>> mount options. This can fail if a user specifies different mount options.
>> Fix this by using new _test_remount() call that remounts $TEST_DEV.
> Looks technically correct, but I still wonder why it's needed at all,
> I can't see anything in the test that would remount the filesystem
> read-only.  git history isn't a help here as the remount goes back to
> the first public revision.

Anyway I think it won't hurt to apply this patch at first and then probably remove this part at all.

Best regards,
Pavel Shilovsky.

More information about the samba-technical mailing list