[PATCH v2 1/3] generic/013: encapsulate remount during cleanup

Christoph Hellwig hch at infradead.org
Thu Aug 28 11:08:49 MDT 2014

On Wed, Aug 27, 2014 at 12:28:36AM +0400, Pavel Shilovsky wrote:
> The existing code calls remount for $TEST_DEV with constantly defined
> mount options. This can fail if a user specifies different mount options.
> Fix this by using new _test_remount() call that remounts $TEST_DEV.

Looks technically correct, but I still wonder why it's needed at all,
I can't see anything in the test that would remount the filesystem
read-only.  git history isn't a help here as the remount goes back to
the first public revision.

More information about the samba-technical mailing list