Removing the original params.c parser (was: Re: [PATCH] lib: Remove some unused code)
abartlet at samba.org
Fri Aug 15 03:19:27 MDT 2014
On Fri, 2014-08-15 at 07:52 +0200, Volker Lendecke wrote:
> Review&push would be appreciated!
I'm happy with this, as long as the commit message is changed to
something along the lines of:
This commit removes the original params.c smb.conf parser from 1997 by
Chris Hertel, which has served us very well over the years. The removal
is in favour of using the new tini parser, which as been written under a
BSD licence to support pam_winbind, and is formatted to modern Samba
coding conventions. By using a single parser across the codebase the
pam_winbind code benefits from this library being tested in a broader
set of configurations.
This will help others understand what is going on when they later read
the GIT history.
Chris: I know this is particularly difficult for you, but even for code
that needs as little attention as this, it is important that it be
consistent style-wise with the rest of the codebase. This applies even
in this case, where it came before these conventions and so much else in
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical