Removing the original params.c parser (was: Re: [PATCH] lib: Remove some unused code)

Volker Lendecke Volker.Lendecke at SerNet.DE
Fri Aug 15 03:31:01 MDT 2014

On Fri, Aug 15, 2014 at 09:19:27PM +1200, Andrew Bartlett wrote:
> On Fri, 2014-08-15 at 07:52 +0200, Volker Lendecke wrote:
> > Hi!
> > 
> > Review&push would be appreciated!
> I'm happy with this, as long as the commit message is changed to
> something along the lines of:
> This commit removes the original params.c smb.conf parser from 1997 by
> Chris Hertel, which has served us very well over the years.  The removal
> is in favour of using the new tini parser, which as been written under a
> BSD licence to support pam_winbind, and is formatted to modern Samba
> coding conventions.  By using a single parser across the codebase the
> pam_winbind code benefits from this library being tested in a broader
> set of configurations.
> This will help others understand what is going on when they later read
> the GIT history.
> Chris:  I know this is particularly difficult for you, but even for code
> that needs as little attention as this, it is important that it be
> consistent style-wise with the rest of the codebase.  This applies even
> in this case, where it came before these conventions and so much else in
> Samba.  

If this hurts feelings to much, I take back the push
request. If I have to write apologies for every - I have in
a diff in the future, this will really, really become
difficult to code for.


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen, mailto:kontakt at

More information about the samba-technical mailing list