Need for cleanup of idle winbindd child processes...

[Ravindra Channabasappa]

Volker,

Attached is the patch (git diff of master) that has code to make child winbindd processes exit if they are idle.
If the request queue in the child is empty then the child gracefully exits.

This really helps in cases where the setup has many trusted domains.  It lets us use the 'max connections per domain' parameter more freely, I mean without worrying too much about the many idle winbindd processes.


Thanks,
--ravindra




-----Original Message-----
From: Volker Lendecke [mailto:Volker.Lendecke at SerNet.DE] 
Sent: Wednesday, April 23, 2014 12:02 PM
To: Ravindra Channabasappa
Cc: samba-technical at lists.samba.org
Subject: Re: Need for cleanup of idle winbindd child processes...

On Tue, Apr 22, 2014 at 07:20:51PM +0000, Ravindra Channabasappa wrote:
> Yes, I tested using "use mmap = no" option... still see the RSS size 
> increase in the child winibndd.

I'm afraid but then I think the only realistic way to approach this is valgrind. All other alternatives involve very long staring at code.

The good thing is -- this problem is likely be generic enough that if you can reproduce your winbind version on a full Linux distro including valgrind it should show up in a similar way and then apply to your container.

> OS info: Linux localhost2 2.6.24.7 #1 SMP Sun Apr 13
> 14:55:34 PDT 2014 i686 i686 i386 GNU/Linux
> 
> I checked smap data. It indicates heap size increase.
> Approximately 400Kb for every 5000 user logins per run.
> I will raise a samba bug for this.

Well, while raising a bug is a good thing for this. However
-- it's the same people who listen here who will work on this and also ask for the valgrind output :-)

> What about the patch attached? I think it can be used for cleanup of 
> idle winbindd processes.

In your latest Mail I did not see a patch. Do you have a reference to somewhere else?

Thanks,

Volker

--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9 AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen http://www.sernet.de, mailto:kontakt at sernet.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: winbindd_exit_idle_child.patch
Type: application/octet-stream
Size: 1923 bytes
Desc: winbindd_exit_idle_child.patch
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140423/fc7e4d21/attachment.obj>