[PATCH] small KCC fixes

[Kamen Mazdrashki]

On Tue, Apr 22, 2014 at 3:15 PM, Jelmer Vernooij <jelmer at samba.org> wrote:

> On Tue, Apr 22, 2014 at 02:50:41PM +0200, Kamen Mazdrashki wrote:
> > On Tue, Apr 22, 2014 at 1:46 PM, Jelmer Vernooij <jelmer at samba.org>
> wrote:
> > > On Tue, Apr 22, 2014 at 12:55:47PM +0200, Kamen Mazdrashki wrote:
> > > > Thanks Jelmer!
> > > >
> > > > Btw, what do you think about porting those patches to samba 4.0.x,
> 4.1.x?
> > > > Some of them looks like fixing real bugs when building topology?
> > > In principle, it seems like a good idea to backport fixes like this.
> How
> > > did you find them though, and are you sure kcc works properly now?
> > >
> >
> > I was trying to run something like "bin/samba_kcc -H private/sam.ldb
> > --readonly --debug" to see
> > what the output is - it wasn't working so I dig it further. I am
> currently
> > using two IDEs to make
> > light my way in code I have forgotten - PyDev and PyCharm. And they are
> > awesome - constantly
> > 'pylint'-ing the code I am looking at (not to mention highlight for
> > selected var). So I am able to quickly
> > find small and big problems here and there. Surprisingly, there are a
> lot :)
> >
> > Does kcc works properly now? It is hard for me to answer this - it should
> > be working much
> > properly that it was before the patch. But if it is working like totally
> > properly - I am not sure.
> > It seems to me that there is more fixes to be done so it runs without
> > errors for more that one DC in Site :)
> > I hope to be able to test it with more DCs and Sites.
> In that case, it's probably not worth backporting these fixes right now,,
> if it's not clear it's actually going to help users.
>
> The only real benefit from backporting the patch for now is - to allow
people
to make one step further in using samba_kcc. So they can start making real
fixes on the tool.
Anyway, you are right that at this point there is no a big benefit from
doing so.
I will propose this again when I have samba_kcc in more working condition
for
multiple DCs/Sites.

Cheers,
Kamen