replication rename fixes in 4.1
abartlet at samba.org
Wed Apr 16 16:59:58 MDT 2014
On Thu, 2014-04-17 at 00:13 +0200, Stefan (metze) Metzmacher wrote:
> Hi Andrew,
> >>> In the meantime, I see no good reason to loose track of your patches, so
> >>> they are in autobuild for master. Can you please review these two:
> >>> https://git.samba.org/abartlet/samba.git/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/drs-object-corruption
> >> It fails because of an error in my first patch,
> >> I've fixed it in
> >> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-abartlet2
> >> https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=033ccc0b100e1bd1631aeccd6f7cb58b2e9f9e4a
> >> needs your review again.
> >> And I have some minor comments on
> >> https://git.samba.org/?p=metze/samba/wip.git;a=commit;h=7170028a28ba530c0b59af680f41092d5f5e2f64
> > I've added my review, and fixed the blacklist to be more general,
> I don't see any change for this in
> seems to be identical to the one in my branch.
Yeah, I have no idea what happened, probably got lost when undoing the
second hunk. Sorry.
> > but I
> > can't find the right shell script magic to make the
> if [ x$RELEASE = x"somerelease" -o x$RELEASE = x"otherrelease" ]; then
> should do it.
I'll try that. I was using == and that wasn't working.
> > dbcheck-oldrelease.sh code use a whitelist. I've pushed it back to my
> > branch there.
> If you remove the trailing whitespaces in
> that's fine too.
Updated patches have been pushed.
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical