replication rename fixes in 4.1

Stefan (metze) Metzmacher metze at samba.org
Wed Apr 16 16:13:22 MDT 2014


Hi Andrew,

>>> In the meantime, I see no good reason to loose track of your patches, so
>>> they are in autobuild for master.  Can you please review these two:
>>>
>>> https://git.samba.org/abartlet/samba.git/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/drs-object-corruption
>>
>> It fails because of an error in my first patch,
>> I've fixed it in
>> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-abartlet2
>>
>> https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=033ccc0b100e1bd1631aeccd6f7cb58b2e9f9e4a
>> needs your review again.
>>
>> And I have some minor comments on
>> https://git.samba.org/?p=metze/samba/wip.git;a=commit;h=7170028a28ba530c0b59af680f41092d5f5e2f64
> 
> I've added my review, and fixed the blacklist to be more general,

I don't see any change for this in
https://git.samba.org/abartlet/samba.git/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/metze-master4-abartlet2
https://git.samba.org/abartlet/samba.git/?p=abartlet/samba.git/.git;a=commit;h=c388addb40884ab4fc30bda18ad74d5f170fb19a
seems to be identical to the one in my branch.

> but I
> can't find the right shell script magic to make the

if [ x$RELEASE = x"somerelease" -o x$RELEASE = x"otherrelease" ]; then

should do it.

> dbcheck-oldrelease.sh code use a whitelist.  I've pushed it back to my
> branch there.

If you remove the trailing whitespaces in
https://git.samba.org/abartlet/samba.git/?p=abartlet/samba.git/.git;a=commitdiff;h=15032ef138db5e4a779f7bba663e55227be11d30
that's fine too.

metze


More information about the samba-technical mailing list