More recvfile optimizations
jra at samba.org
Tue Apr 15 12:17:43 MDT 2014
On Mon, Apr 14, 2014 at 08:38:54PM +0800, Jones wrote:
> 2014-04-10 19:48 GMT+08:00 Stefan (metze) MetzmacherÂ <metze at samba.org>:
> The big TODO is an existing bug that we don't really check if the
> supports recvfile, a named pipe doesn't support this and a print file
> may also doesn't support
> Hi Metze,
> Well that's good!
> im probably suffered the same issues these days.
> While cooperating cups and samba with RECVFILE enabled,
> if go through SMB1 everything works fine,
> if go through SMB2/3 sometimes failed.
> And log.smbd said:
> [2013/12/10 17:23:53.242016, Â 0] ../source3/rpc_server/srv_pipe_hnd.c:89
> Â Unexpected RPC Fragment size! (53439)
> [2014/03/29 18:51:12.354896, Â 0] ../source3/rpc_server/srv_pipe_hnd.c:89
> Â Unexpected RPC Fragment size! (0)
> Wireshark shows SMB2 write command would return NT_STATUS:
> To way around the write with print type and ipc type i add ugly codeÂ
> intoÂ is_smb2_recvfile_write(), but looks this patch is better one,
> i would try to test again and report status later,
Yes, that got fixed in master with Metze's patchset.
Please re-test on master, and the problem should
be gone. I'm planning to raise a bug to back-port
this fix to 4.1.x.
More information about the samba-technical